🥢 Set _skipRoundTripShares Flag in ERC4626VaultTest (#336)

pcaversaccio · web-flow · commit 2f220d164601 · 2025-08-04T13:25:36.000+02:00
### 🕓 Changelog The test library [`erc4626-tests`](https://github.com/a16z/erc4626-tests) introduced the `_skipRoundTripShares` flag in PR [a16z/erc4626-tests#15](a16z/erc4626-tests#15). When set to `true`, it skips the shares inequality assertions in round‑trip tests. The default value is `false`, but since we favour explicitness, we explicitly set `_skipRoundTripShares = false` in the `ERC4626VaultTest` test `setUp` function. Furthermore, this commit pins [`forge-std`](https://github.com/foundry-rs/forge-std) to commit [`369dd01c808c255765b074c12aa420da33947a65`](foundry-rs/forge-std@369dd01) to temporarily prevent CI test failures in the nightly [`halmos`](https://github.com/a16z/halmos)-based tests (see [foundry-rs/forge-std#705](foundry-rs/forge-std#705)). --------- Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
diff --git a/lib/forge-std b/lib/forge-std
@@ -1 +1 @@
-Subproject commit c7be2a3481f9e51230880bb0949072c7e3a4da82
+Subproject commit 369dd01c808c255765b074c12aa420da33947a65
diff --git a/test/extensions/ERC4626.t.sol b/test/extensions/ERC4626.t.sol
@@ -122,6 +122,7 @@ contract ERC4626VaultTest is ERC4626Test {
         _delta_ = 0;
         _vaultMayBeEmpty = true;
         _unlimitedAmount = true;
+        _skipRoundTripShares = false;
     }
 
     function testInitialSetup() public {

Original file line number	Diff line number	Diff line change
`@@ -122,6 +122,7 @@ contract ERC4626VaultTest is ERC4626Test {`
`122`	`122`	`_delta_ = 0;`
`123`	`123`	`_vaultMayBeEmpty = true;`
`124`	`124`	`_unlimitedAmount = true;`
	`125`	`+ _skipRoundTripShares = false;`
`125`	`126`	`}`
`126`	`127`
`127`	`128`	`function testInitialSetup() public {`