Adjusted the waiting timeout for joint states.

[DongyunRobotis]

Description

• Changed the waiting timeout for the joint topic from 10 seconds to 5 seconds.

[gemini-code-assist]

Hello @DongyunRobotis, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello! Gemini here, providing a summary of this pull request to help everyone get up to speed quickly.

This pull request primarily aims to adjust the waiting timeout for the joint states topic, reducing it from 10 seconds to 5 seconds. This change is intended to potentially improve responsiveness or reduce startup delays related to waiting for joint state information.

In addition to this core functional change, the PR also includes several updates related to package versions and dependencies across the repository, including the introduction of a new interfaces package and an update to the lerobot submodule. These changes appear to be part of a version bump to 0.5.2 for several related packages.

Highlights

• Joint State Timeout Adjustment: The main functional change is the reduction of the waiting timeout for the joint states topic from 10 seconds to 5 seconds. This is noted in the physical_ai_tools changelog.
• New Interfaces Package: A new ROS 2 package, physical_ai_interfaces, is introduced. This package is likely intended to house shared message or service definitions for the physical AI components.
• Version Bumps: The version number is updated from 0.5.1 to 0.5.2 across several packages, including physical_ai_manager, physical_ai_server, and physical_ai_tools. This is reflected in their package.xml, package-lock.json, package.json, and setup.py files.
• Submodule Update: The lerobot submodule has been updated to a new commit (051f361cea23ab7fc218b12453aff9a41e3ce9d1). The specific changes within the submodule are not detailed in this PR's diff, but it indicates an update to that dependency.

Changelog

Click here to see the changelog

• lerobot
  • Updated submodule commit from 82b32dd to 051f361.
• physical_ai_interfaces/package.xml
  • Added new file defining the physical_ai_interfaces ROS 2 package (version 0.5.2).
• physical_ai_manager/CHANGELOG.rst
  • Added new changelog entry for version 0.5.2.
• physical_ai_manager/package-lock.json
  • Updated version from 0.5.1 to 0.5.2.
• physical_ai_manager/package.json
  • Updated version from 0.5.1 to 0.5.2.
• physical_ai_server/CHANGELOG.rst
  • Added new changelog entry for version 0.5.2.
• physical_ai_server/package.xml
  • Updated version from 0.5.1 to 0.5.2.
• physical_ai_server/setup.py
  • Updated version from 0.5.1 to 0.5.2.
• physical_ai_tools/CHANGELOG.rst
  • Added new changelog entry for version 0.5.2.
  • Noted the adjustment of the waiting timeout for joint states.
• physical_ai_tools/package.xml
  • Updated version from 0.5.1 to 0.5.2.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Waiting for the state,
Five seconds now, not ten,
Robots move faster then.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull Request Overview

This PR bumps the version to 0.5.2 across multiple packages, adds a new physical_ai_interfaces package, and updates the lerobot submodule commit.

• Version updated from 0.5.1 → 0.5.2 in physical_ai_tools, physical_ai_server, and physical_ai_manager
• New ROS 2 interfaces package physical_ai_interfaces added
• Submodule lerobot commit updated

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
physical_ai_tools/package.xml	Version bumped to 0.5.2
physical_ai_tools/CHANGELOG.rst	Added entry for adjusted joint‐state timeout
physical_ai_server/setup.py	Version bumped to 0.5.2
physical_ai_server/package.xml	Version bumped to 0.5.2
physical_ai_server/CHANGELOG.rst	Added empty 0.5.2 section
physical_ai_manager/package.json	Version bumped to 0.5.2
physical_ai_manager/CHANGELOG.rst	Added empty 0.5.2 section
physical_ai_interfaces/package.xml (new)	New package file with version 0.5.2
lerobot	Submodule commit updated

Files not reviewed (1)

• physical_ai_manager/package-lock.json: Language not supported

Comments suppressed due to low confidence (1)

physical_ai_server/CHANGELOG.rst:7

• [nitpick] The changelog entry for 0.5.2 shows * None, which can be removed for clarity since it adds noise without any changes.

* None

[gemini-code-assist]

Code Review

This pull request primarily involves version bumps across several ROS packages (to v0.5.2) and the introduction of a new package manifest for physical_ai_interfaces. The core functional change, as described in the title and PR description ('Adjusted the waiting timeout for joint states from 10 seconds to 5 seconds'), is noted in the physical_ai_tools changelog. However, the actual code implementing this timeout adjustment does not appear in the diffs of the files within this repository, and seems to be part of the updated lerobot subproject commit. The metadata changes and version increments are consistent across the modified files.

Summary of Findings

• Core Functional Change Location: The primary change regarding the joint state timeout adjustment is likely within the lerobot subproject, whose commit hash has been updated. This makes the core change not directly reviewable from the provided diffs in this PR.
• XML Formatting (physical_ai_interfaces/package.xml): The new file physical_ai_interfaces/package.xml is missing a newline character at the end of the file. While not critical, it's a common convention to include one. (Severity: low, not commented directly due to review settings).

Merge Readiness

This pull request includes consistent version bumps and metadata updates. However, the main functional change—adjusting the joint state timeout—appears to be within the lerobot subproject, which is not directly reviewable through the diffs presented here.

Due to the lack of visibility into this core code change, I recommend that the author provide more details or a pointer to the specific changes in the submodule as requested in the review comment. Addressing this high severity concern is important before merging to ensure the change is correctly implemented and verified.

As a reviewer, I am not authorized to approve pull requests. Please ensure further review and approval from authorized maintainers after addressing the feedback.

[yun-goon]

Please make the requested edits.

[yun-goon]

Good!

[Woojin-Crive]

LGTM