Skip to content

Conversation

nickshulman
Copy link
Contributor

@nickshulman nickshulman commented Oct 8, 2024

Update resx files with localization.zh-CHS.csv and localization.ja.csv that we got back from translators. The commands that I executed were:

pwiz_tools\Skyline\Executables\DevTools\ResourcesOrganizer\scripts\readResxFiles.bat
pwiz_tools\Skyline\Executables\DevTools\ResourcesOrganizer\scripts\exe\ResourcesOrganizer.exe importLocalizationCsv
pwiz_tools\Skyline\Executables\DevTools\ResourcesOrganizer\scripts\exe\ResourcesOrganizer.exe exportResx ResxFiles.zip
and then unzip "ResxFiles.zip"

localization.zh-CHS.csv
localization.ja.csv

Update resx files with localization.zh-CHS.csv that we got back from translators.
The commands that I executed were:
pwiz_tools\Skyline\Executables\DevTools\ResourcesOrganizer\scripts\readResxFiles.bat
pwiz_tools\Skyline\Executables\DevTools\ResourcesOrganizer\scripts\exe\ResourcesOrganizer.exe importLocalizationCsv
pwiz_tools\Skyline\Executables\DevTools\ResourcesOrganizer\scripts\exe\ResourcesOrganizer.exe exportResx ResxFiles.zip
and then unzip "ResxFiles.zip"
@nickshulman nickshulman changed the title Update Chinese localization files Update Chinese localization files (24.1) Oct 8, 2024
@nickshulman nickshulman changed the title Update Chinese localization files (24.1) Update Chinese and Japanese localization files (24.1) Oct 10, 2024
Copy link
Contributor

@brendanx67 brendanx67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have some punctuation-only changes that are changing from Chinese colons and elipses to Roman punctuation. These changes need to be reverted.

@nickshulman
Copy link
Contributor Author

You have some punctuation-only changes that are changing from Chinese colons and ellipses to Roman punctuation. These changes need to be reverted.

Fixed. It sounds like the .csv files that were sent to the localizers were generated before the July 14th commit "normalize punctuation use across translations".

Copy link
Contributor

@brendanx67 brendanx67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have highlighted 4 remaining cases.

</data>
<data name="lblHardklorSignalToNoise.Text" xml:space="preserve">
<value>最小信噪比(&amp;S)</value>
<value>最小信噪比(&amp;S):</value>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chinese to Roman punctuation change

</data>
<data name="CommandLine_ImportPeptideList_Importing_peptide_list__0__from_file__1____" xml:space="preserve">
<value>正在导入文件 {1} 中的肽段列表 {0}</value>
<value>正在导入文件 {1} 中的肽段列表 {0}...</value>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chinese to Roman punctuation change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Knowing enough Chinese to embarrass myself talking to children, I was curious to learn about the Chinese version of the ellipsis. Apparently it's formally six dots, usually two of those 3-dot characters in a row. https://www.zdic.net/ts/fulu/2019/05/27.html
But if the translators were just using one of the 3-dot characters, obviously go with that. :P It's more consistent with the English version that way.

</data>
<data name="CommandLine_ImportPeptideList_Importing_peptide_lists_from_file__0____" xml:space="preserve">
<value>正在导入文件 {0} 中的肽段列表</value>
<value>正在导入文件 {0} 中的肽段列表...</value>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chinese to Roman punctuation change

</data>
<data name="importFeatureDetectionMenuItem.Text" xml:space="preserve">
<value>特征检测(&amp;F)</value>
<value>特征检测(&amp;F)...</value>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chinese to Roman punctuation change

Copy link
Contributor

@brendanx67 brendanx67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@nickshulman nickshulman merged commit f03660d into Skyline/skyline_24_1 Oct 11, 2024
6 checks passed
@nickshulman nickshulman deleted the Skyline/work/20241008_UpdateLocalizationFiles branch October 11, 2024 14:48
nickshulman added a commit that referenced this pull request Oct 11, 2024
Update Chinese localization files

Update resx files with localization.zh-CHS.csv that we got back from translators.
The commands that I executed were:
pwiz_tools\Skyline\Executables\DevTools\ResourcesOrganizer\scripts\readResxFiles.bat
pwiz_tools\Skyline\Executables\DevTools\ResourcesOrganizer\scripts\exe\ResourcesOrganizer.exe importLocalizationCsv
pwiz_tools\Skyline\Executables\DevTools\ResourcesOrganizer\scripts\exe\ResourcesOrganizer.exe exportResx ResxFiles.zip
and then unzip "ResxFiles.zip"
nickshulman added a commit that referenced this pull request Oct 11, 2024
Update Chinese and Japanese localization files

Update resx files with localization.zh-CHS.csv and localization.ja.csv that we got back from translators.
The commands that I executed were:
pwiz_tools\Skyline\Executables\DevTools\ResourcesOrganizer\scripts\readResxFiles.bat
pwiz_tools\Skyline\Executables\DevTools\ResourcesOrganizer\scripts\exe\ResourcesOrganizer.exe importLocalizationCsv
pwiz_tools\Skyline\Executables\DevTools\ResourcesOrganizer\scripts\exe\ResourcesOrganizer.exe exportResx ResxFiles.zip
and then unzip "ResxFiles.zip"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants