-
Notifications
You must be signed in to change notification settings - Fork 110
Update Chinese and Japanese localization files (24.1) #3188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Chinese and Japanese localization files (24.1) #3188
Conversation
Update resx files with localization.zh-CHS.csv that we got back from translators. The commands that I executed were: pwiz_tools\Skyline\Executables\DevTools\ResourcesOrganizer\scripts\readResxFiles.bat pwiz_tools\Skyline\Executables\DevTools\ResourcesOrganizer\scripts\exe\ResourcesOrganizer.exe importLocalizationCsv pwiz_tools\Skyline\Executables\DevTools\ResourcesOrganizer\scripts\exe\ResourcesOrganizer.exe exportResx ResxFiles.zip and then unzip "ResxFiles.zip"
…LocalizationFiles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have some punctuation-only changes that are changing from Chinese colons and elipses to Roman punctuation. These changes need to be reverted.
…://github.com/ProteoWizard/pwiz into Skyline/work/20241008_UpdateLocalizationFiles
Fixed. It sounds like the .csv files that were sent to the localizers were generated before the July 14th commit "normalize punctuation use across translations". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have highlighted 4 remaining cases.
</data> | ||
<data name="lblHardklorSignalToNoise.Text" xml:space="preserve"> | ||
<value>最小信噪比(&S):</value> | ||
<value>最小信噪比(&S):</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chinese to Roman punctuation change
</data> | ||
<data name="CommandLine_ImportPeptideList_Importing_peptide_list__0__from_file__1____" xml:space="preserve"> | ||
<value>正在导入文件 {1} 中的肽段列表 {0}…</value> | ||
<value>正在导入文件 {1} 中的肽段列表 {0}...</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chinese to Roman punctuation change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Knowing enough Chinese to embarrass myself talking to children, I was curious to learn about the Chinese version of the ellipsis. Apparently it's formally six dots, usually two of those 3-dot characters in a row. https://www.zdic.net/ts/fulu/2019/05/27.html
But if the translators were just using one of the 3-dot characters, obviously go with that. :P It's more consistent with the English version that way.
</data> | ||
<data name="CommandLine_ImportPeptideList_Importing_peptide_lists_from_file__0____" xml:space="preserve"> | ||
<value>正在导入文件 {0} 中的肽段列表…</value> | ||
<value>正在导入文件 {0} 中的肽段列表...</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chinese to Roman punctuation change
</data> | ||
<data name="importFeatureDetectionMenuItem.Text" xml:space="preserve"> | ||
<value>特征检测(&F)…</value> | ||
<value>特征检测(&F)...</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chinese to Roman punctuation change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Update Chinese localization files Update resx files with localization.zh-CHS.csv that we got back from translators. The commands that I executed were: pwiz_tools\Skyline\Executables\DevTools\ResourcesOrganizer\scripts\readResxFiles.bat pwiz_tools\Skyline\Executables\DevTools\ResourcesOrganizer\scripts\exe\ResourcesOrganizer.exe importLocalizationCsv pwiz_tools\Skyline\Executables\DevTools\ResourcesOrganizer\scripts\exe\ResourcesOrganizer.exe exportResx ResxFiles.zip and then unzip "ResxFiles.zip"
Update Chinese and Japanese localization files Update resx files with localization.zh-CHS.csv and localization.ja.csv that we got back from translators. The commands that I executed were: pwiz_tools\Skyline\Executables\DevTools\ResourcesOrganizer\scripts\readResxFiles.bat pwiz_tools\Skyline\Executables\DevTools\ResourcesOrganizer\scripts\exe\ResourcesOrganizer.exe importLocalizationCsv pwiz_tools\Skyline\Executables\DevTools\ResourcesOrganizer\scripts\exe\ResourcesOrganizer.exe exportResx ResxFiles.zip and then unzip "ResxFiles.zip"
Update resx files with localization.zh-CHS.csv and localization.ja.csv that we got back from translators. The commands that I executed were:
localization.zh-CHS.csv
localization.ja.csv