Fix visualization plugin #1073
Open
Fix visualization plugin #1073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by link's visual effects, leading to incorrect force application points. This submission aims to fix the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The force visualization plugin is affected by link's visual effects, leading to incorrect force application points. This submission aims to fix the issue. the test based on px4 v1.15.4 and corresponding gazebo-classic commit ID is
da7206e057703cc645770f02437013358b71e1c0.visualtag, but actually not the position of the force's point of action:cptag:For other models that call this plugin, such as
PX4-Autopilot/Tools/simulation/gazebo-classic/sitl_gazebo-classic/models/advanced_plane/advanced_plane.sdf.jinjaandPX4-Autopilot/Tools/simulation/gazebo-classic/sitl_gazebo-classic/models/glider/glider.sdf, I don't have equipment to test them, but I tried using old settings forplane.sdf, and they will display force as "expected", as shown in following green line: