FailureDetector: use robust timeout checks for motor failure detection #25757
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
When checking the code to write docs for #25756 I found:
Solution
now - hopefully_older_time > timeout
→now > hopefully_older_time + timeout
Changelog Entry
Test coverage
No specific testing at the moment. Plaese review for mistakes. This is just a small improvement. I'll more thoroughly test motor failure detection and do more changes but found it was worth to fix now that I see it.