Fix displayed value in power check #25751
Open
+19
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alue above the low_error_threshold or below the high_error_threshold is reported in AMC
alexcekay
previously approved these changes
Oct 13, 2025
dakejahl
requested changes
Oct 14, 2025
…ly update them when hystersis state changes from false to true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
The displayed voltage in AMC was above the threshold, even though the warning indicated it was below.
Solution
Changed the displayed value to the last observed value that was below the threshold, instead of the current value
Test coverage
-Manually checked displayed value in AMC