Skip to content

Conversation

asherikov
Copy link
Contributor

  • enable building in a cmake subdirectory:
    • use consistent path to "etc" in build directory
    • add a quick fix for mavlink inclusion with mavlink/<version>/mavlink.h, presumably the problem does not appear normally since somewhere the build root directory is added to include paths.
  • install gazebo config and plugins, the goal is to enable packaging of PX4 sitl binaries.
  • fix dependency on dds_topics.h generation in uxrce_dds_client: *** No rule to make target 'PX4-Autopilot/src/modules/uxrce_dds_client/dds_topics.h', needed by 'PX4-Autopilot/events/px4.json'. Stop. [Bug] SITL targets not getting built #21788

- enable building in a cmake subdirectory:
    - use consistent path to "etc" in build directory
    - add a quick fix for mavlink inclusion with
      `mavlink/<version>/mavlink.h`, presumably the problem does not
      appear normally since somewhere the build root directory is added
      to include paths.
- install gazebo config and plugins, the goal is to enable packaging of
  PX4 sitl binaries.
- fix dependency on dds_topics.h generation in uxrce_dds_client:
  *** No rule to make target 'PX4-Autopilot/src/modules/uxrce_dds_client/dds_topics.h', needed by 'PX4-Autopilot/events/px4.json'.  Stop.
  PX4#21788
@mrpollo mrpollo requested a review from dagar October 13, 2025 15:39
Copy link
Contributor

@dakejahl dakejahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these changes make sense and look good to me. Thanks for the fix for the dds cmake build as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants