ci: build targets: package cannode artifacts #25731
Draft
+77
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakejahl
changed the title
…arget>/*.uavcan.bin Releases were include the .px4 file for cannodes. This file cannot be flashed and instead the .uavcan.bin file must be used. Updated build script to only package .px4 binaries for non-cannodes and to only package .uavcan.bin binaries for cannodes.
dakejahl
force-pushed
the
pr-cannode_release_artifacts
branch
from
9edc9fa to
565bf31
Compare
|
Build all targets was failing due to duplicate "files" definitions. |
|
No flaws found |
mrpollo
reviewed
Oct 15, 2025
| files: artifacts/*.px4 | ||
| files: | | ||
| artifacts/*.px4 | ||
| artifacts/cannode/**/*.uavcan.bin |
There was a problem hiding this comment.
Should these files also be uploaded to S3?
| mkdir artifacts | ||
| cp **/**/*.px4 artifacts/ | ||
| cp **/**/*.elf artifacts/ | ||
| mkdir -p artifacts/cannode |
There was a problem hiding this comment.
Having a cannode directory seems redundant to me, but I don't understand how flashing a cannode works. Is this the tree you intended to create?
❯ tree .
.
├── ark_can-flow-mr_canbootloader
│ ├── airframes.xml
│ ├── parameters.json
│ ├── parameters.json.xz
│ └── parameters.xml
├── ark_can-flow-mr_canbootloader.elf
├── ark_can-flow-mr_canbootloader.px4
├── ark_can-rtk-gps_canbootloader
│ ├── airframes.xml
│ ├── parameters.json
│ ├── parameters.json.xz
│ └── parameters.xml
├── ark_can-rtk-gps_canbootloader.elf
├── ark_can-rtk-gps_canbootloader.px4
├── ark_cannode_canbootloader
│ ├── airframes.xml
│ ├── parameters.json
│ ├── parameters.json.xz
│ └── parameters.xml
├── ark_cannode_canbootloader.elf
├── ark_cannode_canbootloader.px4
├── ark_f9p-gps_canbootloader
│ ├── airframes.xml
│ ├── parameters.json
│ ├── parameters.json.xz
│ └── parameters.xml
├── ark_f9p-gps_canbootloader.elf
├── ark_f9p-gps_canbootloader.px4
├── ark_teseo-gps_canbootloader
│ ├── airframes.xml
│ ├── parameters.json
│ ├── parameters.json.xz
│ └── parameters.xml
├── ark_teseo-gps_canbootloader.elf
├── ark_teseo-gps_canbootloader.px4
├── ark_x20-gps_canbootloader
│ ├── airframes.xml
│ ├── parameters.json
│ ├── parameters.json.xz
│ └── parameters.xml
├── ark_x20-gps_canbootloader.elf
├── ark_x20-gps_canbootloader.px4
└── cannode
├── ark_can-rtk-gps
│ └── 82-1.16.56e94ece.uavcan.bin
├── ark_cannode
│ └── 83-1.16.56e94ece.uavcan.bin
├── ark_f9p-gps
│ └── 90-1.16.56e94ece.uavcan.bin
└── ark_x20-gps
└── 89-1.16.56e94ece.uavcan.bin
12 directories, 40 files
| files: artifacts/*.px4 | ||
| files: | | ||
| artifacts/*.px4 | ||
| artifacts/cannode/**/*.uavcan.bin |
There was a problem hiding this comment.
Do you also need to upload to S3?
There was a problem hiding this comment.
Also, this won't create a cannode directory in the release assets, it will only upload the *.uavcan.*bin files next to the *.px4 files
|
Need to look into the code to see if we can rename the cannode binaries. The binary names are cryptic and having binaries with names like 90-1.16.56e94ece.uavcan.bin in the github release assets won't be much help for users who are looking for "ark flow firmware" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
Upload
.uavcan.binbinaries for cannode targets and do not upload their.px4files.Fixes #25621
Fixes #25622
Changelog Entry
For release notes:
Test coverage
Tested locally that the artifacts/ directory is structured accordingly.
Context
Copilot tried and got close, but Claude had to save the day
#25705