astyle: remove max line length

[dakejahl]

Opinion
Enforcing line length hurts readability by indenting logical one liners. IMO there isn't much point, I think most people have big monitors and would rather horizontally scroll than having broken up code scattered throughout.

Alternative
Bump to 140

Example
It's especially bad with one-liners that also contain a long comment on the same line
https://github.com/PX4/PX4-Autopilot/blob/main/src/modules/ekf2/EKF2.hpp#L506-L507

[mrpollo]

I'm ok with this

[hamishwillee]

I'm awesome with this. Though there might be a logical reason to have some limit.

EDIT One such logical limit might be how long lines work in github reviews.

[dakejahl]

Thanks for the feedback @hamishwillee @mrpollo. Doesn't seem like anyone else has any feedback. Approve and merge?

[hamishwillee]

@MaEtUgR Do you care about this one?

[mrpollo]

IMO, the limit is a good thing. I have seen people try to be "clever" with one-liners that go beyond the current limit. This is a good way to stop that behavior; however, it's also a bit restrictive for everyone else. Why don't we bump to a higher character limit instead?

[dakejahl]

IMO the occasional long line is better than crap like this.
https://github.com/PX4/PX4-Autopilot/blob/main/src/modules/ekf2/EKF/common.h#L570-L595

There are also lots examples of one liners that are long by necessity (think class constructor inheritance with templates). My preference is to not chop up code on arbitrary boundaries like line length. I do agree that some people may try to be clever with one-liners that are too long and it would be good to prevent that, but in this case the cure is worse than the disease.

[sfuhrer]

I'm in favor of keeping a line length limit, am open to increase it to 140.