Mag Calibration: require enabled / available mag #25714
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem & Solution
Previously, it was possible to trigger magnetometer calibration even when all available magnetometers were disabled via their priority parameter. This created a confusing situation where:
This change adds a validation check before calibration starts, counting only magnetometers with priority != 0. If no enabled magnetometers are found, the calibration gets rejected.
To fix this scenario, users must either:
Test Coverage
Tested on hardware with internal and external sensor.