-
Notifications
You must be signed in to change notification settings - Fork 14.6k
Consume speedweight from FW longitudinal config #25709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔎 FLASH Analysispx4_fmu-v5x [Total VM Diff: 112 byte (0.01 %)]
px4_fmu-v6x [Total VM Diff: 104 byte (0.01 %)]
Updated: 2025-10-08T13:53:55 |
mahima-yoga
reviewed
Oct 8, 2025
src/modules/fw_lateral_longitudinal_control/FwLateralLongitudinalControl.cpp
Outdated
Show resolved
Hide resolved
@mahima-yoga Thanks for the review! Is there anything more I can address to get this in? |
mahima-yoga
approved these changes
Oct 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! To me it looks fine 👍 Can you check CI?
@mahima-yoga I believe theCI failures are not related to this PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
When trying to enable pure airspeed control with the ROS 2 fixedwing control API, it was apparent that the speed weight of TECS was not exposed by the control API.
Solution
Expose the speedweight to be configured through the ROS 2 API
Changelog Entry
For release notes:
Alternatives
Test coverage
Tested in SITL. The following log shows how the vehicle behaves to a equivalent airspeed setpoint of 12m/s
Context
Related links, screenshot before/after, video