Skip to content

Conversation

niklaut
Copy link
Contributor

@niklaut niklaut commented Oct 6, 2025

Solved Problem

We found that the MAVLINK_MSG_ID_AUTOPILOT_VERSION message would return 0 for the board id on FMUv6s.
The implementation calls
https://github.com/Auterion/PX4_firmware_private/blob/a60aa1d9887cb7e7ffd926908d0ef7ec5053ce0c/src/lib/version/version.c#L292-L299

which depends on CONFIG_CDCACM_PRODUCTID being defined.

Since the board doesn't have a USB, the entire CONFIG_CDCACM module was removed and all it's config too.
Whoops.

Solution

Define CONFIG_CDCACM_PRODUCTID manually in the board_config.h. It doesn't work to just define it in the KConfig as the entire CDCACM driver is not enabled, thus the config options are not generated.

Changelog Entry

For release notes:

[mavlink] Fix board id version for FMUv6s

Alternatives

We could also use the bootloader id instead (as one would expect).

Test coverage

  • Tested in hardware

@niklaut niklaut force-pushed the fix/fmuv6s_board_id branch 2 times, most recently from bbb9188 to 5321c1a Compare October 7, 2025 12:14
@niklaut niklaut marked this pull request as ready for review October 7, 2025 12:17
@niklaut niklaut marked this pull request as draft October 7, 2025 12:43
@niklaut niklaut marked this pull request as ready for review October 7, 2025 12:44
Copy link

@alexVinarskis-auterion alexVinarskis-auterion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, confirmed working.

@niklaut niklaut requested a review from alexcekay October 7, 2025 13:49
@niklaut
Copy link
Contributor Author

niklaut commented Oct 7, 2025

FMUv6x at 100.01% flash, even though I didn't change anything for it

@niklaut niklaut force-pushed the fix/fmuv6s_board_id branch from 5321c1a to d91c3fd Compare October 8, 2025 12:49
@niklaut niklaut force-pushed the fix/fmuv6s_board_id branch from d91c3fd to d9d594e Compare October 15, 2025 10:56
@niklaut niklaut merged commit c2fb489 into main Oct 15, 2025
70 of 71 checks passed
@niklaut niklaut deleted the fix/fmuv6s_board_id branch October 15, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants