[FMUv6s] Communicate the correct board id version #25708
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
We found that the
MAVLINK_MSG_ID_AUTOPILOT_VERSION
message would return 0 for the board id on FMUv6s.The implementation calls
https://github.com/Auterion/PX4_firmware_private/blob/a60aa1d9887cb7e7ffd926908d0ef7ec5053ce0c/src/lib/version/version.c#L292-L299
which depends on
CONFIG_CDCACM_PRODUCTID
being defined.Since the board doesn't have a USB, the entire CONFIG_CDCACM module was removed and all it's config too.
Whoops.
Solution
Define
CONFIG_CDCACM_PRODUCTID
manually in theboard_config.h
. It doesn't work to just define it in the KConfig as the entire CDCACM driver is not enabled, thus the config options are not generated.Changelog Entry
For release notes:
Alternatives
We could also use the bootloader id instead (as one would expect).
Test coverage