MAVLink PARAM_ERROR support #25699
Draft
MAVLink PARAM_ERROR support #25699
+87
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishwillee
commented
Oct 2, 2025
hamishwillee
commented
Oct 2, 2025
Comment on lines
208
to
220
| const int result = send_param(param_find_no_notification(name)); | ||
|
|
||
| if (result == 1) { | ||
| PX4_ERR("unknown param name: %s", name); | ||
| send_error(MAV_PARAM_ERROR_DOES_NOT_EXIST, name,-1 , msg->sysid, msg->compid); | ||
|
|
||
| } else if (result == 2) { | ||
| PX4_ERR("Failed loading param from storage: %s", name); | ||
| // send_error(MAV_PARAM_ERROR_??? ,name, -1 , msg.sysid, msg.compid); | ||
| // This case means the parameter could not be populated in param_get. | ||
| // It does exist though. TODO work out right error code. | ||
| } | ||
| } |
There was a problem hiding this comment.
Note this path was being ignored - reporting an error if a named param can't be sent. I copied the same approach as for below (setting and invalid index)
🔎 FLASH Analysispx4_fmu-v5x [Total VM Diff: 536 byte (0.03 %)]px4_fmu-v6x [Total VM Diff: 528 byte (0.03 %)]Updated: 2025-10-09T07:37:41 |
added 2 commits
October 8, 2025 16:41
hamishwillee
force-pushed
the
pr_mavlink_param_error
branch
from
e2b90d3 to
33c9350
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAVLink recently added the WIP PARAM_ERROR message in mavlink/mavlink#2344, which is supposed to be emitted when a parameter can't be set or read, providing error information. This is useful because otherwise the GCS doesn't know if it has just missed the message so it will retry.
This attempts to implement. But I need help because even though I can see the paths and it compiles, I'm not seeing the message in the output.