-
Notifications
You must be signed in to change notification settings - Fork 14.6k
rc_update: remove 1% deadzone for RC channels 1-8 #25502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔎 FLASH Analysispx4_fmu-v5x [Total VM Diff: -968 byte (-0.05 %)]
px4_fmu-v6x [Total VM Diff: -880 byte (-0.04 %)]
Updated: 2025-10-14T05:26:57 |
Yes getting rid of some unnecessary params is always highly appreciated. I also never seen anybody touching them. The interesting dead-zones are the mode-dependent ones.
And we'll probably need to update QGC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted params make me happy
this should be handled higher level.
Regular expression: RC.{0,2}_DZ
b825a4e
to
b6d2fb4
Compare
Because of the positive feedback I went through the draft again to check for any remaining reference to these parameters and found:
It's in the separate commit for review convenience: b6d2fb4 So we should save even a bit more resources now. What's open is the check in QGC what implications it has. |
Great, thanks, looks good.
Let's do that then now! |
src/modules/commander/HealthAndArmingChecks/checks/rcCalibrationCheck.cpp
Show resolved
Hide resolved
No flaws found |
Solved Problem
When I joined PX4 development I assumed this is part of a sophisticated RC calibration plan but in fact it just adds a 1% deadzone to all RC channels 1-8 and does nothing for the rest of the channels 9-18. Pretty random and not something I've seen anyone ever tweak or benefit much from.
The main problem is that if you want a deadzone or not highly depends on the use case of the input. And a deadzone of 1% only helps with very precise stick hardware.
Solution
I suggest to remove this deprecated deadzone mechanism.
The next step is to instead offer one higher-level stick deadzone setting, which also applies to joystick input, only applies in places where a deadzone is necessary/desired and can be adjusted depending on the accuracy of the stick hardware.
Changelog Entry
Test coverage
Not tested yet.