-
Notifications
You must be signed in to change notification settings - Fork 14.6k
Improve multicopter sequential desaturation unit testing #25138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkueng
reviewed
Jul 7, 2025
src/lib/control_allocation/control_allocation/ControlAllocationSequentialDesaturationTest1.cpp
Outdated
Show resolved
Hide resolved
This reverts commit f7dadd9.
…uplicating definitions
from information previously only available in the commit message.
afa69d1
to
24808d9
Compare
…ture This makes it much easier to go through allocation secnarios in one line with comprehensive numbers.
…st cases to improved fixture
… terms of parameter update and defaulting to no airmode
24808d9
to
29bf7b4
Compare
I rebased on |
bkueng
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
When working on limited airmode #22706 I found that:
Control Allocation Sequential Desaturation unit tests #22612
Maintenance: Fix sequential desaturation unit test dependency #24735
purge old mixing system #20108
Solution
ActuatorVector
alias to be defined and used consistently.MC: Multirotor mixer rewrite & Airmode for Yaw #10962
Changelog Entry
Test coverage
I went through these unit tests quite a bit also to check which ones need to be adjusted to support limited airmode. But on the current logic, they still all pass like before, no surprises there.
Context
This is a good intermediate step to allow for proper testing of limited airmode and hexarotor motor failures. But to support those features there's still remaining work to be done even though I already made quite some progress.