Skip to content

Conversation

MaEtUgR
Copy link
Member

@MaEtUgR MaEtUgR commented Jul 1, 2025

Solved Problem

When working on limited airmode #22706 I found that:

Solution

  1. I added a hexarotor geometry to effectiveness generation test.
  2. I took over my unit test only dependency fix from Maintenance: Fix sequential desaturation unit test dependency #24735 (FYI @Jaeyoung-Lim )
  3. I cleaned up the use of the ActuatorVector alias to be defined and used consistently.
  4. I overhauled the entire desaturation unit tests to:
    • Use the test fixture I came up with that allows for having one line per test case with comprehensive numbers
    • Include the tests I had come up with so far
    • Include the already existing tests but adapted to the fixture
    • Include the quadrotor X tests from the original mixer introduced in
      MC: Multirotor mixer rewrite & Airmode for Yaw #10962

Changelog Entry

Improve multicopter sequential desaturation unit testing

Test coverage

I went through these unit tests quite a bit also to check which ones need to be adjusted to support limited airmode. But on the current logic, they still all pass like before, no surprises there.

Context

This is a good intermediate step to allow for proper testing of limited airmode and hexarotor motor failures. But to support those features there's still remaining work to be done even though I already made quite some progress.

@MaEtUgR MaEtUgR force-pushed the maetugr/sequential-desaturation-test-overhaul branch from afa69d1 to 24808d9 Compare July 22, 2025 16:01
MaEtUgR added 4 commits July 22, 2025 18:44
…ture

This makes it much easier to go through allocation secnarios in one line with comprehensive numbers.
… terms of parameter update and defaulting to no airmode
@MaEtUgR MaEtUgR force-pushed the maetugr/sequential-desaturation-test-overhaul branch from 24808d9 to 29bf7b4 Compare July 22, 2025 17:17
@MaEtUgR
Copy link
Member Author

MaEtUgR commented Jul 22, 2025

I rebased on main and addressed the comment. Any other feedback?

@MaEtUgR MaEtUgR merged commit 359cad3 into main Jul 28, 2025
70 checks passed
@MaEtUgR MaEtUgR deleted the maetugr/sequential-desaturation-test-overhaul branch July 28, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants