Add lidar model #25078
Open
Add lidar model #25078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pedro-Roque
requested changes
Jun 18, 2025
.gitmodules
Outdated
There was a problem hiding this comment.
This should not be changed. If you need changes from your side, you need to merge them in PX4/PX4-gazebo-models first. Please open a pull-request there.
There was a problem hiding this comment.
where is the plugin source?
There was a problem hiding this comment.
this vehicle seems like a copy of gz_x500, is this a change of mesh?
|
No flaws found |
|
please rebase and always provide a PR description |
AndriiChumak145
force-pushed
the
add-lidar-model
branch
from
22bda70 to
0e6e554
Compare
AndriiChumak145
force-pushed
the
add-lidar-model
branch
from
0e6e554 to
9b08ad5
Compare
|
@Bisclet please let us know if you plan to address the above, otherwise we will have to close the PR. Thanks! |
Pedro-Roque
reviewed
Oct 9, 2025
Comment on lines
+77
to
+78
| url = git@github.com:OpenHORYZN/PX4-gazebo-models.git | ||
| branch = add-lidar-model |
There was a problem hiding this comment.
For reference, this should be https://github.com/PX4/PX4-gazebo-models.git and the branch should point to your PR branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
When ... I found that ...
Fixes #{Github issue ID}
Solution
Changelog Entry
For release notes:
Alternatives
We could also ...
Test coverage
Context
Related links, screenshot before/after, video