Skip to content

Uxrce dds reduce rate limits #24924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2025
Merged

Uxrce dds reduce rate limits #24924

merged 2 commits into from
Jun 2, 2025

Conversation

GuillaumeLaine
Copy link
Contributor

This implements a suggested follow up to #24765

Changes:

  • Apply lower DDS publication rates than default 100 Hz for data which is not required at a high frequency
  • Update docs to reflect new rate limits

FYI @sfuhrer @bresch

@github-actions GitHub Actions
Copy link

No flaws found

@mrpollo mrpollo mentioned this pull request May 27, 2025
Closed
sfuhrer
sfuhrer approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@sfuhrer sfuhrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. Likely we could even go lower for some topics (e.g. airspeed). But better to start conservatively.

@sfuhrer sfuhrer requested review from beniaminopozzan and bresch May 28, 2025 12:44
beniaminopozzan
beniaminopozzan approved these changes May 29, 2025
View reviewed changes
Copy link
Member

@beniaminopozzan beniaminopozzan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GuillaumeLaine

@sfuhrer sfuhrer merged commit 99f974e into PX4:main Jun 2, 2025
68 checks passed
PedromcaMartins pushed a commit to PedromcaMartins/PX4-Autopilot that referenced this pull request Jul 14, 2025
feat uXRCE DDS topics: Add rate limit code from PX4#24924 and add rat…
a68ab45 
…e limits for new topics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bresch bresch bresch approved these changes

@sfuhrer sfuhrer sfuhrer approved these changes

@beniaminopozzan beniaminopozzan beniaminopozzan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeLaine @bresch @sfuhrer @beniaminopozzan