-
Notifications
You must be signed in to change notification settings - Fork 14.6k
Vehicle_odometry: protect angular_velocity field against aliasing #24916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔎 FLASH Analysispx4_fmu-v5x [Total VM Diff: -48 byte (-0 %)]
px4_fmu-v6x [Total VM Diff: -56 byte (-0 %)]
Updated: 2025-05-27T14:19:41 |
6a5b736
to
f28018c
Compare
Accumulate delta-angles between each publication to get the correct angular velocity between two attitudes
f28018c
to
e11790e
Compare
haumarco
approved these changes
Jun 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
External system using
vehicle_odometry
might want to use theangular_velocity
field as a source of low-rate gyro data for another estimator. Currently, this signal is subject to aliasing as the last imu data is used to fill the message instead of properly down-sampling the gyro data.Solution
Accumulate delta-angles between each publication to get the correct angular velocity between two attitudes.
The resulting angular velocity is not the average of the gyro measurements, but the time derivative of shortest rotation (delta_angle) between two unaided attitudes. The angular velocity is bias-corrected (using the bias estimate of the EKF) but otherwise not directly affected by other aiding sources.
Changelog Entry
For release notes:
Test coverage
Tested on hardware (sensor_combined @ 200Hz, vehicle_odometry @ 100Hz)
