-
Notifications
You must be signed in to change notification settings - Fork 14.6k
[EKF2] Run simplified GNSS checks after initial fix #24909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔎 FLASH Analysispx4_fmu-v5x [Total VM Diff: 216 byte (0.01 %)]
px4_fmu-v6x [Total VM Diff: 216 byte (0.01 %)]
Updated: 2025-06-05T09:14:59 |
e4a1fd9
to
78abe87
Compare
baddbcd
to
ab8791c
Compare
Why do we want to always use the simplified checks? Shouldn't this be something which can be configured by the user? Are the current thresholds not really, really high? Or should it simply be a better sanity check and we let the test-ratio do the proper evaluation? |
This prevents stopping GNSS fusion on slightly degraded solution when tight checks are set
ab8791c
to
f1773e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After further discussion and comparison to previous versions of GNSS checks in PX4, I also think this is a good approach to loosen the checks. About the specific magnitude of the new thresholds I'm still not 100% sure since I could not test with "real"/in-air scenarios where GNSS gets bad all of the sudden.
Here's a test of starting outdoors and then moving indoors.
log_142_2025-6-6-15-19-52.zip
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: https://discuss.px4.io/t/wiki-errors-for-ek2-gps-check/45940/10 |
requires #24908
Solved Problem
Thresholds of GNSS checks are supposed to be tight enough to make sure the drone starts with a good initial fix. However, currently, degradation of a single metric also stops the fusion (e.g.: high DOP) when other metrics are still good.
Solution
Add a "simplified" list of checks with large (arbitrary) thresholds. Those values can be discussed, but hopefully we can agree on a common value to avoid additional parameters.
Changelog Entry
For release notes:
Test coverage
unit tests
@haumarco flight tested