[agaist other PR] FW API rework: address review inputs #24886
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahima-yoga
reviewed
May 20, 2025
src/modules/fw_lateral_longitudinal_control/FwLateralLongitudinalControl.cpp
Show resolved
Hide resolved
KonradRudin
reviewed
May 21, 2025
| _tecs.set_airspeed_rate_measurement_std_dev(_param_speed_rate_standard_dev.get()); | ||
| _tecs.set_airspeed_filter_process_std_dev(_param_process_noise_standard_dev.get()); | ||
|
|
||
| _performance_model.updateParameters(); |
There was a problem hiding this comment.
What i meant in my previous comment is that you seem to update the parameters of the performance model here. But e.g. already in line 88 of this parameters_update function you query values from the performance model (_performance_model.getMaximumClimbRate). Should you update the performance model before?
There was a problem hiding this comment.
Ah right, fixed it further in 23a4854
sfuhrer
force-pushed
the
pr-fw_ctrl_api_address_review
branch
from
50fb9d7 to
ce7b9d2
Compare
14 tasks
|
Incorporated the changes in #24056 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will squash these commits into the existing ones once you approve, thus only a draft.