IC Engine: allow motor to be stopped without disarming #24877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfuhrer
force-pushed
the
pr-fuel-engine-allow-stop-armed-main
branch
from
07b1a9a to
19e7525
Compare
Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
…isarming Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
sfuhrer
force-pushed
the
pr-fuel-engine-allow-stop-armed-main
branch
from
19e7525 to
34e851c
Compare
perrrre
reviewed
Jun 2, 2025
src/modules/internal_combustion_engine_control/InternalCombustionEngineControl.cpp
Show resolved
Hide resolved
perrrre
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
The request is to stop the engine in flight without disarming the system.
Solution
Set the throttle in the ICE module to NAN in the "Stopped" state, which is then mapped to PWM_DISARMED in the output module.
Changelog Entry
For release notes:
Alternatives
This is partially related to #24684, though the implementations can be fully parallel. Just that generally we want to use NAN to command a motor to stop, while "0" should still spin.
Test coverage
Bench tested: Engine is turned on via AUX1 switch, then stopped and started again.
