-
Notifications
You must be signed in to change notification settings - Fork 14.6k
Baro offset calibration based on GNSS height #24859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔎 FLASH Analysispx4_fmu-v5x [Total VM Diff: 720 byte (0.04 %)]
px4_fmu-v6x [Total VM Diff: 712 byte (0.04 %)]
Updated: 2025-05-27T15:29:53 |
17394df
to
98ee6ae
Compare
…selected as hgt-ref
98ee6ae
to
7344cf0
Compare
bresch
requested changes
May 20, 2025
bresch
requested changes
May 21, 2025
… is small enough and gnss data is consistent with baro
bresch
reviewed
May 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, otherwise good to go!
bresch
previously approved these changes
May 27, 2025
bresch
approved these changes
Jun 2, 2025
This was referenced Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
Account for baro offset between GNSS heigth and baro height from very beginning. Store it as offset, since its not a bias but a "fixed" value from the start.
Solution
When vehicle is still on the ground, GNSS-height gets fused and GNSS is selected as the height reference (EKF2_HGT_REF) then the baro pressure offset gets adjusted to match the GNSS height.
Test coverage
Tested on hardware