VehicleCommand.msg - update existing to docs standard

[hamishwillee]

This updates the docs in VehicleMessage uorb topic to match our current docs standard, as discussed in #24574 (review) . There is no semantic change - merging this should change nothing.

But, when we start fixing things, it should be easier to see the changes.

NOTE, it primarily updates the existing docs. I haven't tried to add anything to this.

[hamishwillee]

@sfuhrer I think the error in CI is invalid - I certainly did not intend to modify the content of the message.

Do you know if this check looks for modifications to fields etc, or is just looking at any file changes? If the later this is probably invalid - I can't see anything actually changed - as far as I can tell everything before the # is the same.

IF necessary I can redo this in separate commits to prove this.

[mrpollo]

My two cents: We should bump the version regardless, since this is a change irrespective of whether fields/values are the same as before.

@bkueng @sfuhrer any thoughts?

[hamishwillee]

I still need know if the checker spots any change or meaningful changes. Because if it captures meaningful changes only, then that means I need to start again since this was only supposed to change the docs.

[hamishwillee]

My two cents: We should bump the version regardless, since this is a change irrespective of whether fields/values are the same as before.

OK, I very carefully did this again in #24890 in parts, and then copied the result here. Essentially showed that what triggers that the tests fail do not have to be a semantic change - what triggers it seems quite arbitrary.

I trust this change and I don't think we should bump the version unless there is a "real change". Because if I have to do this just to tidy up docs it is not worth my time vs other things I might be doing.
Unless it will cause an ongoing break/fail in tests?

Can we merge this as is? @mrpollo @bkueng

[bkueng]

The CI failure is a false positive - the version check didn't ignore whitespace. I pushed a fix in aa9809c.

[hamishwillee]

Thanks @bkueng - passing the tests now.

@sfuhrer Can you review. This doesn't have semantic changes - its just updating existing docs to the patterns we agreed for documenting stuff. There is lots more to be done to complete it.

[sfuhrer]

I find no errors, looks clean.

@hamishwillee can you clean up the commits before merging?

[hamishwillee]

@sfuhrer Sure - but doesn't "Squash and merge" do that for you?

[sfuhrer]

@sfuhrer Sure - but doesn't "Squash and merge" do that for you?

Yes, but I meant to keep Beat's commit about the CI change separate of the vehiclecommand update.

[hamishwillee]

Unfortunately I don't know how to unsquish that now.