Skip to content

Conversation

dakejahl
Copy link
Contributor

@dakejahl dakejahl commented May 6, 2025

Previously the system clock was only set if the "offboard" timestamp was valid and the "onboard" timestamp was invalid. This usually is not the desired behavior, since your onboard time could be valid but just hours/days/weeks behind the actual time. A system that sends the SYSTEM_TIME message (eg companion computer application) will update the PX4 time if PX4 is behind by more than a minute.

@dakejahl dakejahl requested a review from MaEtUgR May 6, 2025 03:17
Copy link

github-actions bot commented May 6, 2025

🔎 FLASH Analysis

px4_fmu-v5x [Total VM Diff: 64 byte (0 %)]
    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%     +64  +0.0%     +64    .text
  +0.0%     +61  +0.0%     +61    [section .text]
  +0.2%      +3  +0.2%      +3    ../../src/systemcmds/ver/ver.cpp
+0.0%     +56  [ = ]       0    .debug_abbrev
   +11%     +56  [ = ]       0    ../../src/lib/version/version.c
-0.0%      -8  [ = ]       0    .debug_aranges
  -5.0%      -8  [ = ]       0    ../../src/lib/version/version.c
+0.0%     +69  [ = ]       0    .debug_info
  -0.2%      -4  [ = ]       0    ../../src/lib/version/version.c
  +0.0%     +73  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
+0.0%     +11  [ = ]       0    .debug_line
  -1.3%     -25  [ = ]       0    ../../src/lib/version/version.c
  +0.0%     +34  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
  +0.2%      +2  [ = ]       0    task/task_cancelpt.c
-0.0%      -9  [ = ]       0    .debug_loc
  -0.0%      -9  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
-0.0%      -8  [ = ]       0    .debug_ranges
  -2.6%      -8  [ = ]       0    ../../src/lib/version/version.c
+0.0%      +5  [ = ]       0    .debug_str
  +0.0%      +5  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
-0.1%     -64  [ = ]       0    [Unmapped]
+0.0%    +116  +0.0%     +64    TOTAL

px4_fmu-v6x [Total VM Diff: 56 byte (0 %)]
    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%     +56  +0.0%     +56    .text
+0.0%     +56  [ = ]       0    .debug_abbrev
   +11%     +56  [ = ]       0    ../../src/lib/version/version.c
-0.0%      -8  [ = ]       0    .debug_aranges
  -5.0%      -8  [ = ]       0    ../../src/lib/version/version.c
+0.0%     +69  [ = ]       0    .debug_info
  -0.2%      -4  [ = ]       0    ../../src/lib/version/version.c
  +0.0%     +73  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
+0.0%     +11  [ = ]       0    .debug_line
  -1.3%     -25  [ = ]       0    ../../src/lib/version/version.c
  +0.0%     +34  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
  +0.2%      +2  [ = ]       0    task/task_cancelpt.c
+0.0%      +6  [ = ]       0    .debug_loc
  +0.0%      +6  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
-0.0%     -11  [ = ]       0    .debug_ranges
  -2.6%      -8  [ = ]       0    ../../src/lib/version/version.c
  -4.5%      -3  [ = ]       0    task/task_cancelpt.c
+0.0%      +5  [ = ]       0    .debug_str
  +0.0%      +5  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
-0.1%     -56  [ = ]       0    [Unmapped]
+0.0%    +128  +0.0%     +56    TOTAL

Updated: 2025-05-12T04:18:18

@dakejahl dakejahl merged commit 1d5e58b into main May 13, 2025
65 of 66 checks passed
@dakejahl dakejahl deleted the pr-fix_mavlink_set_time branch May 13, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants