Skip to content

Fix reporting of connected battery #24800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025
Merged

Fix reporting of connected battery #24800

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1486db9
Fix reporting of connected battery
DonLakeFlyer May 4, 2025
f1cc315
esc_calibration: simplify the logic and consider battery only connect…
MaEtUgR May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/modules/commander/esc_calibration.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,19 +63,13 @@ bool check_battery_disconnected(orb_advert_t *mavlink_log_pub)

const bool recent_battery_measurement = hrt_absolute_time() < (battery_status_sub.get().timestamp + 1_s);

if (!recent_battery_measurement) {
// We have to send this message for now because "battery unavailable" gets ignored by QGC
if (recent_battery_measurement && battery_status_sub.get().connected) {
calibration_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, "Disconnect battery and try again");
return false;
}

// Make sure battery is reported to be disconnected
if (recent_battery_measurement && !battery_status_sub.get().connected) {
} else {
return true;
}

calibration_log_critical(mavlink_log_pub, CAL_QGC_FAILED_MSG, "Disconnect battery and try again");
return false;
}

static void set_motor_actuators(uORB::Publication<actuator_test_s> &publisher, float value, bool release_control)
Expand Down
Loading