-
Notifications
You must be signed in to change notification settings - Fork 14.6k
Ackermann: Update control structure #24784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46529d5
to
7c831f9
Compare
🔎 FLASH Analysispx4_fmu-v5x [Total VM Diff: -208 byte (-0.01 %)]
px4_fmu-v6x [Total VM Diff: -232 byte (-0.01 %)]
Updated: 2025-05-12T13:12:48 |
86a8e71
to
b1465a3
Compare
bc7c3f8
to
bce5b56
Compare
d44786d
to
e7b8c3e
Compare
e7b8c3e
to
c4e0a40
Compare
Deprecated by #24836 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
This PR updates the ackermann module to the following control structure:

This is done to prepare the rover modules (and the RoverSpecificSetpoints) for access through API and is achieved through the following steps:
Position control now always turns a RoverPositionSetpoint into a RoverVelocitySetpoint which further streamlines the Input/Output flow of the rover specific uORB messages.
To achieve this, the RoverPositionSetpoint is extended with some optional fields.
RoverAckermann
. Based on the control mode, it will generateRoverSetpoints
and udpate the necessary controllers . Further, sanity checks are now only performed on parameter or control mode changes.RoverSetpoints
.Alternative
All functions that generate roverSetpoints (manual modes, offboard, auto, ...) could also be moved to

RoverAckermann
.This way the controllers would only handle their setpoint and publish the setpoint that is one level lower in the hierarchy.
Tests
Tested in SITL
Hardware tests: