Add boat SIH #24778
Add boat SIH #24778
Conversation
bastianhjaeger
force-pushed
the
boat-sih
branch
from
fba8aec to
e46e839
Compare
|
Very cool. When you're done, don't forget to add a docs update to https://docs.px4.io/main/en/sim_sih/ |
bastianhjaeger
force-pushed
the
boat-sih
branch
2 times, most recently
from
cbe0ed0 to
60bad35
Compare
bastianhjaeger
force-pushed
the
boat-sih
branch
from
60bad35 to
93070e4
Compare
|
No flaws found |
|
Seems to have got a little out of date :-( |
There was a problem hiding this comment.
Sorry that one would have been on my to review.
I'm now handing off further reviews to @chfriedrich98 - he's currently on adding SIH for rovers, which is a work item very closely related to to this here.
|
|
||
| param set-default SIH_VEHICLE_TYPE 4 # sih as boat | ||
|
|
||
| #param set-default SIH_MASS 3.0 |
There was a problem hiding this comment.
Better delete unused parameters
| #!/bin/sh | ||
| # Standard apps for an boat. | ||
|
|
||
| # Start rover ackermann module. |
There was a problem hiding this comment.
Add comment that this is only short-term until we have boat controller.
| generate_fw_aerodynamics(_u[4], _u[5], _u[6], 0); | ||
|
|
||
| } else if (_vehicle == VehicleType::Boat) { | ||
| // _T_B = Vector3f(_T_MAX * _u[1], 0.0f, 0.0f); // forward thruster |
| ---help--- | ||
| Enable support for simulator_sih | ||
|
|
||
| if MODULES_SIMULATION_SIMULATOR_SIH |
There was a problem hiding this comment.
Why is that necessary? I don't see the same kconfig options for the other SIH vehicle types.
|
Thanks @sfuhrer ! @bastianhjaeger FYI You have some conflicts. |
4 participants
Solved Problem
No existing SIH for a boat.
Solution
Test coverage