Skip to content

gz small improvements #24761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 4, 2025
Merged

gz small improvements #24761

merged 4 commits into from
May 4, 2025

Conversation

dakejahl
Copy link
Contributor

@dakejahl dakejahl commented Apr 25, 2025

  • print version number in init
  • remove gst plugin spam
  • refactor topic subscriptions
  • fix 0 timestamp issue causing problems with EKF (wait for clock topic before subscribing to others)

@dirksavage88
Copy link
Contributor

I get a lot of libprotobuff spam messages, an idea on how to suppress or fix them? I am using ionic on 24.04 btw
gzprotobuf

@dakejahl
Copy link
Contributor Author

dakejahl commented May 2, 2025

@dirksavage88 a clean build doesn't solve it? I had the same issue and it was resolved be either doing a clean build or uninstalling harmonic

…g to other topics. Refactor to cleanup topic subscriptions
@dakejahl dakejahl force-pushed the pr-gz_sim_startup_output branch from 779d29e to 40673bc Compare May 2, 2025 19:59
@dirksavage88
Copy link
Contributor

@dakejahl uninstalling harmonic did the trick. I guess being on the bleeding edge isn't the greatest user experience haha

Copy link
Contributor

@dirksavage88 dirksavage88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
gz

@dakejahl dakejahl requested a review from beniaminopozzan May 4, 2025 19:17
Copy link
Contributor

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dakejahl dakejahl merged commit 2fece23 into main May 4, 2025
65 of 67 checks passed
@dakejahl dakejahl deleted the pr-gz_sim_startup_output branch May 4, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants