Skip to content

Fix the test data matrix script #24745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jmackay2
Copy link
Contributor

Solved Problem

The matrix test_data.py script did not work.

Solution

  • Add python3 shebang
  • Remove std::sqrt and replace with a python sqrt (**0.5)
  • Add a float epsilon

Alternatives

We could use a python package that does sqrt if we want to be more verbose, but the square function just before is just using python square, so it is probably not necessary.

Test coverage

  • Ran the test_data.py script successfully with the outputs printing correctly

@github-actions github-actions bot added the stale label May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant