Fix the test data matrix script #24745
Open
+5
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
The matrix
test_data.py
script did not work.Solution
std::sqrt
and replace with a python sqrt (**0.5
)Alternatives
We could use a python package that does
sqrt
if we want to be more verbose, but the square function just before is just using python square, so it is probably not necessary.Test coverage
test_data.py
script successfully with the outputs printing correctly