Gazebo simulation tools. #16142
Merged
Gazebo simulation tools. #16142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaeyoung-Lim
requested changes
Nov 9, 2020
There was a problem hiding this comment.
Thanks for the contribution, I have a few questions regarding this PR
- I am a bit concerned that this introduces another way of running SITL which is not part of the CI. How do you see this fit in with other simulations and the already existing
sitl_run.sh? - gz_sim.sh seems to include a duplicate functionality of
gazebo_sitl_multiple_run.share you trying to replace this script? - the
reboot_mavlink_shell.pyseems like a duplicate of boot_now.py, are you trying to replace this script?
Additional:
- The NXP rover model being added to SITL seems orthogonal to the other tool changes, therefore I think it should be a separate PR
bperseghetti
requested review from
Jaeyoung-Lim
and removed request for
bkueng and
jkflying
|
Think this has all the requested changes and should be all good to go. |
|
@bperseghetti Can you clarify on the following points I mentioned above?
|
bperseghetti
changed the title
Jaeyoung-Lim
requested changes
Nov 13, 2020
bperseghetti
force-pushed
the
pr-hitl-tools
branch
3 times, most recently
from
f7772b4 to
1a54a82
Compare
bperseghetti
requested review from
jgoppert
and removed request for
jgoppert
|
What is the next step here? |
… Gazebo with gz_sim.sh, works with PX4-SITL_gazebo PR 651.
jkflying
force-pushed
the
pr-hitl-tools
branch
from
1a54a82 to
830de84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by this pull request
This PR allows for a clean running of gazebo simulation for sitl and hitl with gz_sim.sh and advanced runtime generation of worlds and models. This is used in conjunction with PR 651 in PX4-SITL_gazebo.
Test data / coverage
Tested extensively.