Add FW loiter size and orientation control #24625
Open
+26
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Params 3 and 4 handling are missing. This adds it in. Param 3 now will respond to a loiter size and param 4 to 0/1 for CW/CCW. Also, on alt only changes if you omit param3/4 it explicitly does what you have set as your default (rather than last done which is how it is now) to ensure you get the default unless the param is passed.
|
Also, this allows QGC to expose loiter size and direction control |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #24612
Params 3 and 4 handling are missing. This adds it in.
Param 3 now will respond to a loiter size and param 4 to 0/1 for CW/CCW.
Also, on alt only changes if you omit param3/4 it explicitly does what you have set as your default (rather than last done which is how it is now) to ensure you get the default unless the param is passed.
https://logs.px4.io/plot_app?log=61232f4d-fa71-4965-bd37-0be6c4740bb8
(Main from today)
https://discord.com/channels/1022170275984457759/1022186266957201480/1224558850179469414
https://discord.com/channels/1022170275984457759/1022186266957201480/1354505832426901546