[FIX] base_tier_validation: ensure skip_validation_check bypasses val… #1158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @LoisRForgeFlow, |
Jord38
force-pushed
the
17.0-fix-base_tier_validation-skip_context_flag
branch
from
5be1557 to
2bd9e1e
Compare
|
@Jord38 could you possibly also add the use of the context flag to the documentation? Similar to https://github.com/OCA/queue/blob/18.0/queue_job/readme/USAGE.md?plain=1#L295 |
Jord38
force-pushed
the
17.0-fix-base_tier_validation-skip_context_flag
branch
from
2bd9e1e to
67d33a6
Compare
Author
@chrisb-c01 |
Jord38
force-pushed
the
17.0-fix-base_tier_validation-skip_context_flag
branch
from
67d33a6 to
352069c
Compare
CasVissers-360ERP
approved these changes
Sep 29, 2025
chrisb-c01
approved these changes
Sep 30, 2025
Author
|
@gurneyalex @pedrobaeza can we get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…idations
context flag check was not present in
_tier_validation_check_state_on_write(vals)and thus I was unable to properly skip the tier validation using the context flag.now moved up to the write method to ensure validation is skipped if context flag is present