Skip to content

Commit 5be1557

Browse files
committed
[FIX] base_tier_validation: ensure skip_validation_check bypasses validations
1 parent bbc54d2 commit 5be1557

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

base_tier_validation/__manifest__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
{
44
"name": "Base Tier Validation",
55
"summary": "Implement a validation process based on tiers.",
6-
"version": "17.0.4.0.0",
6+
"version": "17.0.4.0.1",
77
"development_status": "Mature",
88
"maintainers": ["LoisRForgeFlow"],
99
"category": "Tools",

base_tier_validation/models/tier_validation.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -371,13 +371,14 @@ def _check_tier_state_transition(self, vals):
371371
) not in (self._state_to + [self._cancel_state])
372372

373373
def write(self, vals):
374-
self._tier_validation_check_state_on_write(vals)
375-
self._tier_validation_check_write_allowed(vals)
376-
self._tier_validation_check_write_remove_reviews(vals)
374+
if not self._context.get("skip_validation_check"):
375+
self._tier_validation_check_state_on_write(vals)
376+
self._tier_validation_check_write_allowed(vals)
377+
self._tier_validation_check_write_remove_reviews(vals)
377378
return super().write(vals)
378379

379380
def _write(self, vals):
380-
if self._tier_validation_state_field_is_computed:
381+
if self._tier_validation_state_field_is_computed and not self._context.get("skip_validation_check"):
381382
self._tier_validation_check_state_on_write(vals)
382383
self._tier_validation_check_write_remove_reviews(vals)
383384
return super()._write(vals)
@@ -437,7 +438,6 @@ def _tier_validation_check_write_allowed(self, vals):
437438
rec.review_ids
438439
and rec._check_tier_state_transition(vals)
439440
and not rec._check_allow_write_under_validation(vals)
440-
and not rec._context.get("skip_validation_check")
441441
):
442442
(
443443
allowed_fields,
@@ -464,7 +464,6 @@ def _tier_validation_check_write_allowed(self, vals):
464464
and rec._tier_validation_get_current_state_value()
465465
in (self._state_to + [self._cancel_state])
466466
and not rec._check_allow_write_after_validation(vals)
467-
and not rec._context.get("skip_validation_check")
468467
):
469468
(
470469
allowed_fields,

0 commit comments

Comments
 (0)