Skip to content

Commit 2bd9e1e

Browse files
committed
[FIX] base_tier_validation: ensure skip_validation_check bypasses validations
1 parent bbc54d2 commit 2bd9e1e

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

base_tier_validation/__manifest__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
{
44
"name": "Base Tier Validation",
55
"summary": "Implement a validation process based on tiers.",
6-
"version": "17.0.4.0.0",
6+
"version": "17.0.4.0.1",
77
"development_status": "Mature",
88
"maintainers": ["LoisRForgeFlow"],
99
"category": "Tools",

base_tier_validation/models/tier_validation.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -371,13 +371,16 @@ def _check_tier_state_transition(self, vals):
371371
) not in (self._state_to + [self._cancel_state])
372372

373373
def write(self, vals):
374-
self._tier_validation_check_state_on_write(vals)
375-
self._tier_validation_check_write_allowed(vals)
376-
self._tier_validation_check_write_remove_reviews(vals)
374+
if not self._context.get("skip_validation_check"):
375+
self._tier_validation_check_state_on_write(vals)
376+
self._tier_validation_check_write_allowed(vals)
377+
self._tier_validation_check_write_remove_reviews(vals)
377378
return super().write(vals)
378379

379380
def _write(self, vals):
380-
if self._tier_validation_state_field_is_computed:
381+
if self._tier_validation_state_field_is_computed and not self._context.get(
382+
"skip_validation_check"
383+
):
381384
self._tier_validation_check_state_on_write(vals)
382385
self._tier_validation_check_write_remove_reviews(vals)
383386
return super()._write(vals)
@@ -437,7 +440,6 @@ def _tier_validation_check_write_allowed(self, vals):
437440
rec.review_ids
438441
and rec._check_tier_state_transition(vals)
439442
and not rec._check_allow_write_under_validation(vals)
440-
and not rec._context.get("skip_validation_check")
441443
):
442444
(
443445
allowed_fields,
@@ -464,7 +466,6 @@ def _tier_validation_check_write_allowed(self, vals):
464466
and rec._tier_validation_get_current_state_value()
465467
in (self._state_to + [self._cancel_state])
466468
and not rec._check_allow_write_after_validation(vals)
467-
and not rec._context.get("skip_validation_check")
468469
):
469470
(
470471
allowed_fields,

0 commit comments

Comments
 (0)