-
Notifications
You must be signed in to change notification settings - Fork 57
Minimal viable booster framework #2100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal viable booster framework #2100
Conversation
a1ace88 to
b861543
Compare
d66567b to
c69d509
Compare
|
lol, casually deletes |
I mean, those were all NAO related parameters, right? In the spirit of starting of clean, doing this seems right imo. Every parameter we still need we can simply bring it back, when we implement something that does need it. |
Co-authored-by: pejotejo <149575214+pejotejo@users.noreply.github.com>
Co-authored-by: pejotejo <149575214+pejotejo@users.noreply.github.com> better naming and docs Co-authored-by: pejotejo <149575214+pejotejo@users.noreply.github.com>
Add mujoco connection test Add time stamped message type --wip--
Co-authored-by: Rasmus Mecklenburg <42248344+rmburg@users.noreply.github.com> Co-authored-by: Julian Schuler <31921487+julianschuler@users.noreply.github.com> Co-authored-by: knoellle <33729490+knoellle@users.noreply.github.com>
Co-authored-by: knoellle <33729490+knoellle@users.noreply.github.com>
0a183fb to
531aa48
Compare
In my experience, restoring lost functionality can sometimes be more difficult than expected. Our old walking engine had fairly good catching steps. It took us two? years to restore them. |
823c457 to
d835fc2
Compare
I understand your hesitance to simply get rid of the result of years of tuning trial and error. I would really like to stress, that the information in the Those are my two cents, but this is absolutely still up for discussion. Any other opinions/arguments from the team? |
d835fc2 to
8cefebd
Compare
We talked extensively about how to handle the transition to K1 last wednesday and came to the conclusion that deleting stuff is better than keeping things where we don't know if it still works. |
8cefebd to
6056097
Compare
|
Someone with the correct permission has to change the required CI jobs for this to be able to merge. |
6056097 to
84d1620
Compare
Why? What?
We are moving robot platforms to the Booster Robotics K1. To facilitate this change, we have decided to fully move our codebase to this new platform and discontinue our development on the NAO Platform.
This PR removes the
hulk_naobinary crate, thehulk_webotscrate as well as some related ones. In exchange it adds ahulk_mujocobinary crate. This is a binary that executes the framework and robotics code while providing a hardware interface to a mujoco simulator and is comparable in use case to thehulk_webotscrate, which it replaces. The mujoco simulator is currently being developed here.The CI has also been changed to not build the
hulk_naoandhulk_webotscrate and instead build thehulk_mujococrate.Additionally the test job was temporarily disabled, since the execution of the bevyhavior simulator scenarios depend on parameters which were NAO specific. The bevyhavior simulator is definitely still useful for the new platform, but extensive rework is required there and that is out of scope for this PR, since the behavior simulation is not as crucial for now.
ToDo / Known Issues
If this is a WIP describe which problems are to be fixed.
Ideas for Next Iterations (Not This PR)
How to Test
mujoco-simulatorrunuv run main.pyto start the simulator.tools/mujoco-rust-server/frontend/runnpm iand thennpm run devto start the simulator visualizer../pepsi run mujoco