Test the CaptureManager #1555
Merged
Test the CaptureManager #1555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
scottopell
approved these changes
Oct 10, 2025
There was a problem hiding this comment.
https://github.com/DataDog/lading/blob/main/lading/src/bin/lading.rs#L695-L721
is also potentially of interest here
100%, I had this test in mind. It's problematic because it assumes immediate flush of data. As this stack continues that test will eventually disappear. |
blt
changed the base branch from
blt/migrate_the_capture_manager_into_lading_capture
to
graphite-base/1555
This commit ensures that the counter!/gauge! macros are able to result in CaptureManager recording capture lines. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Co-authored-by: Scott Opell <me@scottopell.com>
blt
force-pushed
the
blt/test_the_capturemanager
branch
from
3695595 to
180aea4
Compare
This was referenced Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit ensures that the counter!/gauge! macros are able to result
in CaptureManager recording capture lines.