Migrate the capture manager into lading_capture #1554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit migrates the `CaptureManager` from `lading` crate -- where it is used in lading binary -- the `lading_capture crate. This is intended to facilitate a non-trivial rework of our capture subsystem. This is an extraction from #1553 which has grown too unwieldy. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
This stack of pull requests is managed by Graphite. Learn more about stacking. |
GeorgeHahn
approved these changes
Oct 9, 2025
This was referenced Oct 9, 2025
This was referenced Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit migrates the
CaptureManagerfromladingcrate -- where it is used in lading binary -- the `lading_capture crate. This is intended to facilitate a non-trivial rework of our capture subsystem. This is an extraction from #1553 which has grown too unwieldy.