AP_Scripting: fixed battery tag on 2nd CAN bus #31159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow for tags on either bus
|
I confirm now the script works on CAN2 as well. |
peterbarker
reviewed
Sep 26, 2025
| local function check_batterytag() | ||
| local payload, nodeid = batterytag_handle:check_message() | ||
| local function check_batterytag(bus) | ||
| local payload, nodeid = batterytag_handles[bus]:check_message() |
There was a problem hiding this comment.
What happens here if there is only 1 bus?
| batterytag_handle:subscribe() | ||
| local batterytag_handles = { | ||
| DroneCAN_Handle(0, BATTERYTAG_SIGNATURE, BATTERYTAG_ID), | ||
| DroneCAN_Handle(1, BATTERYTAG_SIGNATURE, BATTERYTAG_ID) |
There was a problem hiding this comment.
I guess this holds us until someone uses a three-interface device :-)
I tested it on a single bus (both first and 2nd bus) in SITL |
OK, that's weird. I was expecting the response to be, "yes, we will git a method-on-nil exception there". shrug. |
peterbarker
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow for tags on either bus