AP_Periph: fix notify vehicle_state bit-length bug #31082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
reviewed
Sep 23, 2025
Whoops, not sure how I missed that one. Fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AP_Periph: fix notify vehicle_state bit-length bug
The CAN notify message value is a uint64 value which the main
vehicle_statevariable is so thats correct but the accessors for it is uint32. Whoops! While I was tripped up on that I also thought thelast_vehicle_statewas a backup to check for change but it was a ms timer and so the uint32 was correct so I renamed it tolast_vehicle_state_msfor clarity.