-
Notifications
You must be signed in to change notification settings - Fork 19.6k
BRGR scripts merge with master #31026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[](https://autotest.ardupilot.org/) | ||
|
||
ArduPilot is the most advanced, full-featured, and reliable open source autopilot software available. | ||
ArduPilot is the most advanced, full-featured, and reliable open source autopilot software availabll |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
???
Also, please fix the lua linting issues and the ⛔ symbol at the end of several .lua files.
Checking ROMFS_custom/scripts/grid_fin_mixing.lua 2 warnings
Error: ROMFS_custom/scripts/grid_fin_mixing.lua:44:19: value assigned to variable V_air is unused
Error: ROMFS_custom/scripts/grid_fin_mixing.lua:114:11: unused variable effective_aoa
Checking ROMFS_custom/scripts/lockouts.lua 1 warning
Error: ROMFS_custom/scripts/lockouts.lua:123:9: empty if branch
@@ -1,3 +1,4 @@ | |||
/ArduPlane/ap-*.core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message should explain this proposed change.
…er location over land.
… nil this afternoon to test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this is quite an interesting PR!
Did you really mean to create a merge to master ArduPilot for your code? This looks more like an "OEM" setup which you've accidentally PRd?
Some things in here would be good to get into master, but most of this wouldn't be suitable as it currently stands.
No answer, assuming someone goofed here. |
Merge BRGR-autopilot which contains scripts with master