Skip to content

ArduSub: improve turn counting #30011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ArduSub: improve turn counting #30011

wants to merge 1 commit into from
+7 −36

Conversation

ES-Alexander
Copy link
Contributor

@ES-Alexander ES-Alexander commented May 8, 2025 •
edited
Loading

  • cast output to float, for extra precision that is already part of the tracking
    • it's already being sent as a NAMED_VALUE_FLOAT, so we may as well use the precision we have
  • handle an incorrect edge-case
    • radians(90) would incorrectly register as state 3 instead of 1
  • clean up the state tracking code

@ES-Alexander ES-Alexander mentioned this pull request May 8, 2025
Merged
@ES-Alexander ES-Alexander force-pushed the Sub-improve-turn-counting branch from ebf0b78 to bd567e0 Compare May 8, 2025 14:54
@peterbarker peterbarker added the Sub label May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Williangalvani Williangalvani Awaiting requested review from Williangalvani

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Sub
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ES-Alexander @peterbarker