Skip to content

Tools: ros2: Reduce test code duplication with fixture reuse #30003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

Tools: ros2: Reduce test code duplication with fixture reuse #30003

merged 1 commit into from
May 13, 2025

Conversation

Ryanf55
Copy link
Contributor

@Ryanf55 Ryanf55 commented May 7, 2025 •
edited
Loading

  • Normally these go in conftest and are auto-imported by pytest, but LaunchPytest requires any fixtures to be statically visible at import time and imported directly
  • By moving these fixtures into a common file, we reduce the amount of code duplication for our tests

@Ryanf55
Tools: ros2: Reduce test duplication with fixture reuse
0a1210c 
* Normally these go in conftest and are auto-imported by pytest, but
  LaunchPytest requires any fixtures to be statically visible at import
time and imported directly

Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com>
@Ryanf55 Ryanf55 requested a review from srmainwaring May 7, 2025 05:41
@Ryanf55 Ryanf55 added the ROS label May 7, 2025
@Ryanf55 Ryanf55 changed the title Tools: ros2: Reduce test duplication with fixture reuse Tools: ros2: Reduce test code duplication with fixture reuse May 7, 2025
@andyp1per andyp1per merged commit 7aa6cb8 into ArduPilot:master May 13, 2025
102 checks passed
@Ryanf55 Ryanf55 deleted the dds-reduce-test-code-duplication branch May 14, 2025 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tizianofiorenzani tizianofiorenzani tizianofiorenzani approved these changes

@andyp1per andyp1per andyp1per approved these changes

@srmainwaring srmainwaring Awaiting requested review from srmainwaring

Assignees
No one assigned
Labels
CI Non-Functional Change ROS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ryanf55 @tizianofiorenzani @andyp1per @IamPete1