AP_Periph: added BatteryTag support #29983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
force-pushed
the
pr-BatteryTag
branch
3 times, most recently
from
78988a0 to
cb0fd13
Compare
tpwrules
reviewed
May 13, 2025
| information about number of cycles a battery has been through along | ||
| with the serial number and number of hours in an armed state. | ||
|
|
||
| The log message in BTAG |
There was a problem hiding this comment.
Did you forget to finish a thought?
There was a problem hiding this comment.
Pretty sure this needs to be filled out with some
rmackay9
approved these changes
May 13, 2025
peterbarker
reviewed
May 13, 2025
Tools/AP_Periph/can.cpp
Outdated
| @@ -524,6 +524,21 @@ void AP_Periph_FW::handle_arming_status(CanardInstance* canard_instance, CanardR | |||
| } | |||
|
|
|||
|
|
|||
| #if AP_PERIPH_RTC_ENABLED | |||
There was a problem hiding this comment.
Suggested change
| #if AP_PERIPH_RTC_ENABLED | |
| #if AP_PERIPH_RTC_GLOBALTIME_ENABLED |
peterbarker
requested changes
May 13, 2025
|
@peterbarker added AP_PERIPH_RTC_GLOBALTIME_ENABLED |
peterbarker
approved these changes
May 15, 2025
Tools/AP_Periph/battery_tag.cpp
Outdated
Comment on lines
16
to
19
| battery info support. This feature has a set of parameters which are | ||
| controlled by a lua script on the FMU. The battery infomation node | ||
| is attached to a specific battery and recorded the number of cycles, | ||
| and total armed time |
There was a problem hiding this comment.
Not sure this is entirely accurate now.
| information about number of cycles a battery has been through along | ||
| with the serial number and number of hours in an armed state. | ||
|
|
||
| The log message in BTAG |
There was a problem hiding this comment.
Pretty sure this needs to be filled out with some
this implements a battery tag node that is permanently attached to a battery to give information on armed hours and cycles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for BatteryTag functionality in AP_Periph, along with a lua script for logging and handling battery tags.
A batterytag is a DroneCAN node that is permanently attached to the battery to record battery cycles and armed time. It is helpful for managing battery lifetime. Note that the batterytag may not have access to the battery voltage/current/state-of-charge
split from #29310 as requested by @tpwrules