-
Couldn't load subscription status.
- Fork 2.6k
FlightPlanner: fix zero-alt warning for ArduPlane #3591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
FlightPlanner: fix zero-alt warning for ArduPlane #3591
Conversation
cf8d277 to
dfe2826
Compare
|
I have overhauled I also removed the blank placeholders in the languages that don't have a translation. Turns out that if you have a blank placeholder, then that's what gets printed. We don't want that. Leaving it out makes it fall back to the English translation. TODO:
|
|
@meee1 the CI failure seems to be somehow unrelated to this PR (a recent change on the default runner maybe?). I just ran it on master on my fork and got the same error: Edit: got it to work by pinning the windows runner to Windows-2022 for the Android workflow |
|
Discussed this on the dev call, and Tridge has signed off on the message and logic (for plane). |
|
this is still in draft? |
I was holding off to test the Android and mono builds just to be safe (been struggling to test it personally), and I wanted Andras to provide a translation for the new message, but I won't hold this up for it. I'll just mark it ready. |
Support for longer messages and general code cleanup
e25b230 to
1f37cf0
Compare



Draft PR. I've run out of time today. I'll try to come back to this next week or Andras can maybe finish it; just want to get what I have out there.
So, on Copter, pretty much any nav command with 0 altitude means "keep current altitude". On Plane, this is only true for loiters (and only relative altitude). Waypoints in plane will happily use 0 as a true 0. I haven't tested across different releases yet.
I only just realized this today. The recent addition trying to inform users about the nuances of 0-alt commands (#3574) is actually dangerously wrong for plane users.
We probably need an emergency release after this.
TODO: