TerrainMaker: fix csproj #3597
Merged
TerrainMaker: fix csproj #3597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous project file was causing MissionPlanner.exe to be unnecessarily copied into the plugins output directory. I could not find a way to prevent that with a small incremental change, so I switched over to the same boilerplate as the other plugins.
|
Need to fix android build |
|
Sorry, I did not realized that the project file causing it. Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous project file was causing MissionPlanner.exe to be unnecessarily copied into the plugins output directory. In addition to
being wasteful in the zip CI artifacts(update, just learned that the cleanup step deletes it, so not a big deal), it causes issues when building the .msi installer (edit: only locally, in CI the cleanup takes care of it). I could not find a way to prevent that with a small incremental change, so I switched over to the same boilerplate as the other plugins (which I break down here).I have tested that the terrain maker plugin still builds/works.