Skip to content

MAVLinkInterface: plane guided error #3518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

MAVLinkInterface: plane guided error #3518

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b61167
MAVLinkInterface: delete unnecessary giveComport
robertlong13 Apr 3, 2025
d11b04b
MAVLinkInterface: cleanup setNewWPAlt
robertlong13 Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions ExtLibs/ArduPilot/Mavlink/MAVLinkInterface.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4422,8 +4422,6 @@ public void setGuidedModeWP(byte sysid, byte compid, Locationwp gotohere, bool s
if (gotohere.alt == 0 || gotohere.lat == 0 || gotohere.lng == 0)
return;

giveComport = true;

try
{
gotohere.id = (ushort) MAV_CMD.WAYPOINT;
Expand All @@ -4444,7 +4442,6 @@ public void setGuidedModeWP(byte sysid, byte compid, Locationwp gotohere, bool s

if (ans != MAV_MISSION_RESULT.MAV_MISSION_ACCEPTED)
{
giveComport = false;
throw new Exception("Guided Mode Failed");
}
}
Expand All @@ -4459,8 +4456,6 @@ public void setGuidedModeWP(byte sysid, byte compid, Locationwp gotohere, bool s
{
log.Error(ex);
}

giveComport = false;
}

[Obsolete]
Expand All @@ -4482,7 +4477,6 @@ public void setNewWPAlt(byte sysid, byte compid, Locationwp gotohere)

if (ans != MAV_MISSION_RESULT.MAV_MISSION_ACCEPTED)
{
giveComport = false;
throw new Exception("Alt Change Failed");
}

Expand All @@ -4495,12 +4489,9 @@ public void setNewWPAlt(byte sysid, byte compid, Locationwp gotohere)
}
catch (Exception ex)
{
giveComport = false;
log.Error(ex);
throw;
}

giveComport = false;
}

public void setPositionTargetGlobalInt(byte sysid, byte compid, bool pos, bool vel, bool acc, bool yaw,
Expand Down
Loading