soc: silabs: s2: make order in soc Kconfig's #93456
Conversation
zephyrbot
requested review from
asmellby,
jerome-pouiller,
jhedberg and
Martinhoff-maker
yishai1999
force-pushed
the
silabs-soc-order
branch
2 times, most recently
from
80270f9 to
17aa5d2
Compare
| config SOC_SERIES_EFR32MG21 | ||
| bool | ||
| select SOC_SERIES_XG21 | ||
| help | ||
| Silicon Labs EFR32MG21 (Mighty Gecko) Series MCU |
There was a problem hiding this comment.
no this is not how soc series Kconfigs work, they do not select each other, only one is selected
There was a problem hiding this comment.
Ok. Do you have a suggestion of what to call it instead? They hierarchy is efr32mg21 < xg21 < silbas_s2 so I'm not sure how to refer to each? Series? Family? What additional term can I use?
There was a problem hiding this comment.
family: silabs_s2
- series: xg21
- name: efr32mg21 (assuming this is the name of the soc)
There was a problem hiding this comment.
No, the soc would be efr32mg21a020f1024im32 for example so efr32mg21a020f1024im32 < efr32mg21 < xg21 < silbas_s2
There was a problem hiding this comment.
then one of those is going to need to be dropped, it is described on https://docs.zephyrproject.org/latest/hardware/porting/board_porting.html#hardware-support-hierarchy
There was a problem hiding this comment.
That's unfortunate. @asmellby, What's your take on this? I think there should be some way to consolidate some of the kconfig options by utilizing the xg2y grouping
There was a problem hiding this comment.
As I see it, the following information is needed:
efr32mg21in order to construct the CMSIS-Device include path in hal_silabs ("device family" in CMSIS and Silabs terms, currently mapped to "series" in hwmv2)xg21in order to have a single symbol to use to avoid complex expressions when multiple device families share a platform ("generic family" in Silabs terms)silabs_s2for the umbrella of platforms in the same generation ("series" in Silabs terms, currently mapped to "family" in hwmv2)
IMO the easiest way out might be to not try to make xg21 be part of the hwmv2 model, and instead declare it like architecture/cpu is done: by doing the definition and select in Kconfig, not Kconfig.soc, and guarding it behind SOC_FAMILY_SILABS_S2. I'm not sure what the symbol should be called, though -- "generic family" doesn't work since family/series has the opposite meaning in Zephyr. Maybe simply SOC_SILABS_XG21?
There was a problem hiding this comment.
The idea is that in future there will be no selections of these symbols (i.e. other than selecting a SOC_MY_SOC from a board - perhaps, or this might be done automatically too) and all SOC_* symbols will be automatically selected by the build system, so adding that does not fit in to that but would need to wait for @tejlmand to get back from vacation to comment on the suitability because the automatic build system parts is his idea
yishai1999
force-pushed
the
silabs-soc-order
branch
from
17aa5d2 to
39cba63
Compare
Made some order in the Kconfig's for silabs series 2 socs. Made a distinction between silabs "generic family" (e.g. xg21) and silabs "device family" (e.g. efr32mg21). Signed-off-by: Yishai Jaffe <yishai1999@gmail.com>
yishai1999
force-pushed
the
silabs-soc-order
branch
from
39cba63 to
9a128cb
Compare
|
Made some order in the Kconfig's for silabs series 2 socs.