-
Notifications
You must be signed in to change notification settings - Fork 7.7k
boards: st nucleo c071rb fix LED, Button, SPI configuration #93351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
str4t0m
wants to merge
2
commits into
zephyrproject-rtos:main
Choose a base branch
from
str4t0m:st_nucleo_c071rb_fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+9
−7
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test will fail when the SCK pin is connected to PA5 because it shares the pin with led0.
Besides PA6 and PA7 are also shared with I2C2 node.
I suggest keeping the current configuration and update documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh thanks, I overlooked the i2c2, as I didn't add that to the nucleo_c091rc.
But I still think the SPI should be mapped to the arduino header, otherwise no arduino uno shield can be used with SPI(w/o manually wiring it up, which is not really practicalbe).
What do you think about the current proposal of moving the I2C2 to the morpho header. As such shields with SPI can be used as long as the button is not used at the same time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I understand you thoughts ,
To align with your proposal, i suggest you please to create a new commits with the following changes :
SPI :
add this line
pinctrl-0 = <&spi1_nss_pb0 &spi1_sck_pb3 &spi1_miso_pb4 &spi1_mosi_pb5>;
before
zephyr/tests/drivers/spi/spi_loopback/boards/nucleo_c071rb.overlay
Line 8 in 47b07e5
I2C
add this line
pinctrl-0 = <&i2c2_scl_pa7 &i2c2_sda_pa6>;
beforezephyr/tests/drivers/i2c/i2c_target_api/boards/nucleo_c071rb.overlay
Line 25 in 47b07e5
These changes will help avoid regressions in the related tests.