boards: st nucleo c071rb fix LED, Button, SPI configuration #93351
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The user button does not have a dedicated pull-up resistor on the board, therefore activate the internal pull-up. - The pin for LD2 does not switch the via a transistor, but directly sinks the current of the LED, therefore we need to set it active low. Signed-off-by: Thomas Stranger <thomas.stranger@outlook.com>
This commit changes the spi1 pins to pa15, pa5, pa6, pa7. The SPI instance has been declared as arduino_spi, but different pins have been used. Signed-off-by: Thomas Stranger <thomas.stranger@outlook.com>
|
zephyrbot
requested review from
djiatsaf-st,
erwango,
etienne-lms,
FRASTM,
gautierg-st,
GeorgeCGV,
marwaiehm-st and
mathieuchopstm
djiatsaf-st
requested changes
Jul 21, 2025
| @@ -135,8 +135,9 @@ | |||
| }; | |||
|
|
|||
| &spi1 { | |||
| pinctrl-0 = <&spi1_nss_pb0 &spi1_sck_pb3 | |||
| &spi1_miso_pb4 &spi1_mosi_pb5>; | |||
| /* Note: PA5 is shared with green led0 */ | |||
There was a problem hiding this comment.
The test will fail when the SCK pin is connected to PA5 because it shares the pin with led0.
Besides PA6 and PA7 are also shared with I2C2 node.
I suggest keeping the current configuration and update documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working with the
nucleo_c092rcI noticed a few issues in thenucleo_c071rbboard configuration that I propose to fix in this PR:I don't have a
nucleo_c071rbto verify these changes, but tested it on a board that is basically only a different assembly option.